Add LazilyParsedNumber default adapter #2060
Merged
+204
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eamonnmcmanus
requested changes
Jan 26, 2022
| HTML_SAFE_REPLACEMENT_CHARS['\''] = "\\u0027"; | ||
|
|
||
| // Syntax as defined by https://datatracker.ietf.org/doc/html/rfc8259#section-6 | ||
| VALID_JSON_NUMBER_PATTERN = Pattern.compile("-?(?:0|[1-9][0-9]*(?:\\.[0-9]+)?(?:[eE][-+]?[0-9]+)?)"); |
There was a problem hiding this comment.
Google's tests found a problem with this: the string 0.8252564 is rejected. I think it should be:
-?(?:0|[1-9][0-9]*)(?:\\.[0-9]+)?(?:[eE][-+]?[0-9]+)?
I removed the outermost group because it doesn't seem necessary.
There was a problem hiding this comment.
Also, could you just make this an initializer on VALID_JSON_NUMBER_PATTERN? Unlike the other fields here it's just a plain initialization. You might want to move it before those other fields so they remain next to the static {} block that initializes them.
There was a problem hiding this comment.
You are right, the pattern was incorrect, thanks a lot for noticing this! I have fixed it and also added more tests for this.
eamonnmcmanus
approved these changes
Jan 28, 2022
Marcono1234
deleted the
marcono1234/LazilyParsedNumber-default-adapter
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #847
Additionally adds validation for
JsonWriter.value(Number)argument to avoid creation malformed JSON output by accident whenNumber.toString()does not return a valid JSON number.