Only import errorprone.annotations with optional (if at all)

[laeubi]

Gson version

2.12.0

Java / Android version

any java version

Used tools

• Maven; version:
• Gradle; version:
• ProGuard (attach the configuration file please); version:
• ...

Description

Currently the gson release requires in its manifest:

com.google.errorprone.annotations;version="[2.36,3)"

this requires to pull in the error prone annotations to the OSGi runtime.

Expected behavior

The annotations should only be imported with optional

com.google.errorprone.annotations;version="[2.36,3)";resolution:=optional

because they are not interesting/required at runtime, see also

• Make annotations class retention only error-prone#4797

or not imported at all.

[eamonnmcmanus]

See this comment and the discussion it links to. Unless you have reason to think the situation has evolved, this doesn't seem like something we want to change.

[laeubi]

Unless you have reason to think the situation has evolved, this doesn't seem like something we want to change.

Maven optional (compile time) is something completely with OSGi optional (runtime), the jar is already compiled at this stage so it can't lead to any "cryptic compiler message", so I'd like to ask to reopen this please!

[chrisrueger]

@eamonnmcmanus I support @laeubi in this regard and would encourage to reopen.

This topic is similar to my work done in #2735 and is about runtime and resolving bundles in an OSGi context. Without resolution:=optional all OSGi applications now need to add error-prone as a runtime depedency to their OSGi applications.

[laeubi]

Especially the last version of the artifact don't seem to use that header at all

[eamonnmcmanus]

OK. To be honest, OSGi support is something of an annoyance to the project maintainers, since none of us has expertise in it or uses it in any way. As recently as yesterday I was forced to spend quite some time figuring out how to adjust the OSGi configuration, and I seriously contemplated just removing it from the project. However, apparently some people do need it, presumably because of Eclipse, and this change is probably harmless.