Skip to content

Conversation

@netdpb
Copy link
Member

@netdpb netdpb commented Jan 6, 2020

This code has been reviewed and submitted internally. Feel free to discuss on
the PR, and we can submit follow-up changes as necessary.

Commits:

Tell maven-javadoc-plugin to target JDK 8

This unbreaks mvn install on AdoptOpenJDK 11.
Presumably it unbreaks on all JDKs >= 11.

Fixes #429

db389b1

This unbreaks `mvn install` on AdoptOpenJDK 11.
Presumably it unbreaks on all JDKs >= 11.

Fixes #429

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=288016119
@googlebot
Copy link

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@googlebot
Copy link

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

@netdpb
Copy link
Member Author

netdpb commented Jan 6, 2020

Adding CLA status because the commit originated from @cgrushko's PR #429.

@netdpb netdpb merged commit 1288c85 into master Jan 6, 2020
@netdpb netdpb deleted the sync-master-2020/01/06 branch January 6, 2020 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants