Skip to content

Conversation

@andymanning
Copy link
Contributor

No description provided.

Copy link
Member

@tbpg tbpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! One suggestion, otherwise looks good.

tika/server.go Outdated
Comment on lines 94 to 98
//Check if the jar file exists
_, err := os.Stat(jar)
if os.IsNotExist(err) {
return nil, fmt.Errorf("jar file [%s] does not exist", jar)
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
//Check if the jar file exists
_, err := os.Stat(jar)
if os.IsNotExist(err) {
return nil, fmt.Errorf("jar file [%s] does not exist", jar)
}
// Check if the jar file exists.
if _, err := os.Stat(jar); os.IsNotExist(err) {
return nil, fmt.Errorf("jar file %q does not exist", jar)
}

@tbpg tbpg merged commit 2bffae1 into google:main Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants