Skip to content

Conversation

malt3
Copy link
Contributor

@malt3 malt3 commented Aug 16, 2022

Fixes #283

@google-cla
Copy link

google-cla bot commented Aug 16, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@ericchiang
Copy link
Contributor

@brandonweeks asked for a chance to test this against some of our internal data. Broadly lgtm, but waiting on him

@twitchyliquid64
Copy link
Collaborator

Is it worth actually parsing this and exposing the data?

Otherwise, LGTM.

@malt3
Copy link
Contributor Author

malt3 commented Sep 8, 2022

@brandonweeks if I understand the current state correctly, you wanted to perform tests against internal data. Is there any news or things I can do to help?

Copy link
Contributor

@ericchiang ericchiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving since it looks like Brandon's a bit busy.

@brandonweeks please feel free to roll this back or follow up if you find any issues.

@ericchiang ericchiang merged commit e99c3e1 into google:master Sep 9, 2022
malt3 added a commit to edgelesssys/constellation that referenced this pull request Oct 17, 2022
The reason for replacing the module was waiting for google/go-attestation#284 to be merged.
malt3 added a commit to edgelesssys/constellation that referenced this pull request Oct 17, 2022
The reason for replacing the module was waiting for google/go-attestation#284 to be merged.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rhshim introduced a MokListTrusted event, leading to failed parsing of the SecureBootState
5 participants