webgpu: Support skinning on WebGPU #9137
Draft
+29
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndyHovingh
reviewed
Aug 22, 2025
AndyHovingh
reviewed
Aug 22, 2025
| } | ||
| out << "};\n"; | ||
| out << "const " << STRUCT_NAME << " " << PUSH_CONSTANT_STRUCT_VAR_NAME << " = " | ||
| << STRUCT_NAME << "(0);\n"; |
There was a problem hiding this comment.
I recommend an assert that the pushConstants has one value with the one name we expect. Otherwise, things/assumptions have changed and this part of the code should fail loudly. Also, it makes the hack here more obvious (in addition to your comment).
There was a problem hiding this comment.
i dont get this, what should we assert?
There was a problem hiding this comment.
We are assuming that the pushConstants are just the one that we should hardcode to 0. We should probably assert that it is indeed just the one we are expecting to get. That assumption could change (in the future maybe multiple push constants are requested...).
jc3265
force-pushed
the
jc/supportSkinning
branch
2 times, most recently
from
930fbc1 to
7380706
Compare
jc3265
force-pushed
the
jc/supportSkinning
branch
from
7380706 to
e5c9002
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BUGS = [436886048]