matc: improvements to LineDictionary compression #9078
+300
−61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pixelflinger
force-pushed
the
ma/matc-dico
branch
from
6aa6268 to
bc6c6e0
Compare
pixelflinger
changed the title
We can significantly improve the effectiveness of the line dictionary by splitting lines strategically. spirv optimization tends to create new variable names (e.g. _1234) that are not always stable between variants, hereby preventing lines from being duplicated. By simply splitting lines around these patterns, we improve the effectiveness of the compression. The decompression is almost unchanged. To make the code easier, we now keep the '\n' at the end of lines in the dictionary. That's the only change to the decompression side. On certain materials like aiDefault.mat the compression ratio is improved from 2.8x to 15x. This also fixes a small but where the line dictionary relied on the last line of the input to be a newline.
pixelflinger
force-pushed
the
ma/matc-dico
branch
from
bc6c6e0 to
53bc802
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can significantly improve the effectiveness of the line dictionary
by splitting lines strategically. spirv optimization tends to create
new variable names (e.g. _1234) that are not always stable between
variants, hereby preventing lines from being duplicated. By simply
splitting lines around these patterns, we improve the effectiveness
of the compression.
The decompression is almost unchanged. To make the code easier, we
now keep the '\n' at the end of lines in the dictionary. That's the
only change to the decompression side.
On certain materials like aiDefault.mat the compression ratio is
improved from 2.8x to 15x.
This also fixes a small but where the line dictionary relied on the
last line of the input to be a newline.