Use bytes interface value for zero native type struct fields instead of dynamic list #981
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…of dynamic list If a struct has a byte array/slice field and it happens to be the zero value, a dynamic list object was returned. This caused issues with functions taking `Bytes` via arguments, as the type checker will accept such functions, but they might fail at runtime. To work around this, the raw bytes array/slice is returned in case of an zero value.
patrickpichler
commented
Jul 12, 2024
|
/gcbrun |
patrickpichler
force-pushed
the
fix/zero-values-bytes
branch
from
9e63be1 to
f7b02bd
Compare
|
/gcbrun |
TristonianJones
previously approved these changes
Jul 31, 2024
For most types, it is good enough to use the raw interface values for null types. Hence the logic of getFieldValue has been adjusted to remove some special handling code.
patrickpichler
force-pushed
the
fix/zero-values-bytes
branch
from
f7b02bd to
a817292
Compare
|
/gcbrun |
TristonianJones
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a struct has a byte array/slice field and it happens to be the zero value, a dynamic list object was returned. This caused issues with functions taking
Bytesvia arguments, as the type checker will accept such functions, but they might fail at runtime.To work around this, the raw bytes array/slice is returned in case of an zero value.