run clang-tidy using a common config and reduced set of tests #1923
Conversation
.github/workflows/clang-tidy.yml
Outdated
| @@ -35,4 +35,4 @@ jobs: | |||
| - name: run | |||
| shell: bash | |||
| working-directory: ${{ runner.workspace }}/_build | |||
| run: run-clang-tidy -checks=*,-clang-analyzer-deadcode*,-clang-analyzer-optin* | |||
| run: run-clang-tidy -checks=*,-clang-analyzer-deadcode*,-clang-analyzer-optin*,-fuchsia-*,-llvmlibc-*,-modernize-use-trailing-return-type | |||
There was a problem hiding this comment.
You might want to place this in a .clang-tidy file in the root source directory
There was a problem hiding this comment.
yeah i'm also going to reduce the number of checks we're running.
|
Just a general comment: it might be best to approach this as one check per PR, |
yeah, it's a draft PR so i can split it up later. |
.github/workflows/clang-tidy.yml
Outdated
| @@ -35,4 +35,4 @@ jobs: | |||
| - name: run | |||
| shell: bash | |||
| working-directory: ${{ runner.workspace }}/_build | |||
| run: run-clang-tidy -checks=*,-clang-analyzer-deadcode*,-clang-analyzer-optin* | |||
| run: run-clang-tidy -config-file=${{ runner.workspace }}/.clang-tidy | |||
There was a problem hiding this comment.
It will be picked up automatically
There was a problem hiding this comment.
it's not finding it, which suggests the same as when i passed it explicitly: that it's not running with the root as a parent directory, somehow.
There was a problem hiding this comment.
it finds it locally, fwiw
|
ok fixed it. clang-tidy is now running properly with the common config. |
dmah42
changed the title
No description provided.