-
Notifications
You must be signed in to change notification settings - Fork 141
docs: Enhance Javadoc documentation across core components #189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Enhance Javadoc documentation across core components #189
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Hi Veronika! Thanks for the PR. Really appreciate the efforts to improve the docs. We won't be able to merge this PR for a few reasons.
|
Hi Divyansh! Thank you so much for the detailed feedback! I've simplified the Javadoc, removed redundant parts, and aligned it with the adk-python style where applicable. I'm happy to address any further comments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much for this contribution! Requested a few changes but after that, LGTM!
Hi Alejandro, Thank you for the review! I have made all the requested changes to the Javadoc comments. Please take another look. |
Submission failed due to formatting. Apologies for the churn, but would you mind running the Google formatter on your local changes? We have #210 to eventually do this as part of local build, but it hasn't been merged yet so you'll have to follow any of the instructions here to run the formatter: Line 194 in f53600e
|
Great idea with the plugin! I’ve committed the formatted code — thanks for the detailed instructions on the “simplest way”. That really helped! |
Description
This pull request significantly enhances and standardizes the Javadoc documentation for key classes and methods across 21 files within the
core
package, specifically focusing on the LLM flow and Event handling components.Key Changes & Improvements
LlmFlow
(e.g.,callLlm
,handleBeforeModelCallback
,handleAfterModelCallback
,runOneStep
,run
,runLive
),AgentTransfer
,ExampleUtils
, and various callback-related classes.@param
,@return
,@throws
,{@link}
) and standard formatting for better readability and navigation within IDEs and generated documentation.Rationale & Value Add
This work aims to significantly improve the overall readability, maintainability, and comprehensibility of the codebase. Enhanced Javadoc documentation:
This contribution aligns with best practices for code documentation and directly supports the long-term health and usability of the
adk
project.