Skip to content

Conversation

khyativyasargus
Copy link
Collaborator

Fixes #74

@khyativyasargus khyativyasargus requested a review from MJ1998 January 5, 2024 11:47
Copy link
Collaborator

@MJ1998 MJ1998 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @khyativyasargus
Have you tested it with the sensory app ? I think you need to also remove the screenOrientation from AndroidManifest!

@khyativyasargus
Copy link
Collaborator Author

Thanks @khyativyasargus Have you tested it with the sensory app ? I think you need to also remove the screenOrientation from AndroidManifest!

Yes @MJ1998 , Yes I tested in sensory app and it works without removing screenOrientation!

return rotateImageIfRequired(context, toTransform, uri!!)
}

override fun updateDiskCacheKey(messageDigest: MessageDigest) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we are not caching the image, do we need to override this ?
If this is not mandatory to override, then we can skip it.

@MJ1998
Copy link
Collaborator

MJ1998 commented Jan 15, 2024

Hey @khyativyasargus. I looked into Glide. Seems it automatically handles the exif rotation things.
Do you know why without providing the transform to glide it does not work ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Thumbnail is showing rotated while capturing Image
2 participants