Skip to content

Improving CaptureInfo #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 4, 2024
Merged

Improving CaptureInfo #101

merged 3 commits into from
Apr 4, 2024

Conversation

MJ1998
Copy link
Collaborator

@MJ1998 MJ1998 commented Mar 19, 2024

Fixes #100

  1. Removing the customized CaptureSetting model
  2. Storing CaptureRequest which is, intuitively as well, the request that was used to capture for the CaptureInfoEntity record it belongs to.

chandrashekar-s
chandrashekar-s approved these changes Mar 27, 2024
View reviewed changes
Copy link
Collaborator

@chandrashekar-s chandrashekar-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current changes looks more flexible, thanks for the changes @MJ1998

@MJ1998 MJ1998 merged commit 9e0d7db into google-research:main Apr 4, 2024
This was referenced Apr 4, 2024
Open
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chandrashekar-s chandrashekar-s chandrashekar-s approved these changes

@jingtang10 jingtang10 Awaiting requested review from jingtang10

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Improve CaptureInfo for sensing library

2 participants

@MJ1998 @chandrashekar-s