Skip to content

Conversation

@torchbear
Copy link
Contributor

No description provided.

@ghost
Copy link

ghost commented Mar 7, 2024

Build succeeded (check pipeline).

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 59.34066% with 37 lines in your changes are missing coverage. Please review.

Project coverage is 90.51%. Comparing base (6f76338) to head (790a76e).

Files Patch % Lines
...oddata-sdk/gooddata_sdk/compute/model/execution.py 6.66% 14 Missing ⚠️
gooddata-sdk/gooddata_sdk/visualization.py 14.28% 12 Missing ⚠️
gooddata-sdk/gooddata_sdk/compute/model/filter.py 83.33% 10 Missing ⚠️
gooddata-sdk/gooddata_sdk/compute/model/base.py 50.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #579      +/-   ##
==========================================
- Coverage   90.89%   90.51%   -0.38%     
==========================================
  Files          93       93              
  Lines        6416     6507      +91     
==========================================
+ Hits         5832     5890      +58     
- Misses        584      617      +33     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ghost
Copy link

ghost commented Mar 7, 2024

Build succeeded (check pipeline).

@torchbear torchbear force-pushed the rha/cq-227/stringify-applied-format branch from 332fbb9 to eadec5d Compare March 7, 2024 12:32
@ghost
Copy link

ghost commented Mar 7, 2024

Build succeeded (check pipeline).

Copy link
Contributor

@no23reason no23reason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yenkins
Copy link

yenkins commented Mar 7, 2024

Sonar scan result

More detail, see in https://sonarqube-gate.intgdc.com/dashboard?id=gooddata-python-sdk-gate-PR579

To scan for vulnerabilities in dependencies and run unit tests (to get coverage report in sonar) please comment your PR with 'extended check sonar'.

@ghost ghost removed the merge label Mar 7, 2024
@ghost ghost merged commit 836c3be into master Mar 7, 2024
@ghost ghost deleted the rha/cq-227/stringify-applied-format branch March 7, 2024 13:27
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants