test: storage catalog #1872
Open
test: storage catalog #1872
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofekatr
force-pushed
the
test/storage-catalog
branch
2 times, most recently
from
1fe8da8 to
b1d4e58
Compare
ofekatr
force-pushed
the
test/storage-catalog
branch
from
b1d4e58 to
e4517de
Compare
manugupt1
reviewed
Sep 6, 2023
| "github.com/stretchr/testify/require" | ||
| ) | ||
|
|
||
| func TestCatalog(t *testing.T) { |
There was a problem hiding this comment.
Instead of mocks can we use a real minio set up like here
https://github.com/gomods/athens/blob/main/pkg/storage/minio/minio_test.go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the problem I am trying to address?
Catalogmethod of the MinIO storage implementation, to ensure the authentication token is passed as expected.How is the fix applied?
What GitHub issue(s) does this PR fix or close?
Fixes #1213