FIX: Enable hostname and cert verification #320
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the original code, check_hostname=False and verify_mode=0 effectively turn off SSL certificate validation and that could raise concern regarding security. The updated code enforces ssl.CERT_REQUIRED and keep hostname checking on, ensuring SSL certificates is properly validated results in hardens the connection security by preventing unauthorized or unverified certificates from being accepted. FIX: goldmansachs#319
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the original code, check_hostname=False and verify_mode=0 effectively turn off SSL certificate validation and that could raise concern regarding security. The updated code enforces ssl.CERT_REQUIRED and keep hostname checking on, ensuring SSL certificates is properly validated results in hardens the connection security by preventing unauthorized or unverified certificates from being accepted.
FIX: #319