Switch to cmake for c extension building #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
With this pull we're introducing cmake as a dependency, right? I am not sure the advantages it provides compared to current approach. Isn't a simpler approach with a Makefile possible and easier to manage? With this, ueberzug-tabbed diverges from now not-existent upstream considerably, I am hesitant for such a change. |
|
Cmake would be a make dependency in this case, not a runtime one. The main advantage of using cmake is the creation of a compile_commands.json file, this file is read by clangd and aids in the extension development. The current setup.py solution doesn't have that functionality afaik. Using makefiles wouldn't help either. |
|
How about using ninja instead? |
|
cmake generates the build files, so it can be used with ninja or with make. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.