Skip to content

Bump containerd v2 #345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 17, 2025
Merged

Bump containerd v2 #345

merged 2 commits into from
Jun 17, 2025

Conversation

Fricounet
Copy link
Contributor

This change is needed for dragonflyoss/nydus#1699 but also to keep up with the latest containerd versions.

  • A bunch of other dependencies got bumped as well when running go mod tidy
  • Import paths were modified to match the new containerd/v2 lib.
  • docker v1 support was removed in the ported functions as it was removed in containerd too

Fricounet added 2 commits June 11, 2025 17:58
@Fricounet
[go.mod] Bump containerd to v2
53778f1 
This change is needed for dragonflyoss/nydus#1699 but also to keep up with the latest containerd versions. A bunch of other dependencies got bumped as well when running `go mod tidy`.
Import paths were modified to match the new containerd/v2 lib.

Signed-off-by: Baptiste Girard-Carrabin <[email protected]>
@Fricounet
[ported] Remove dependency on docker schemav1
f1c323c 
It's been removed in containerd v2 so it should be removed from the ported function as well

Signed-off-by: Baptiste Girard-Carrabin <[email protected]>
@Fricounet Fricounet force-pushed the bump-containerd-v2 branch from 77a76eb to f1c323c Compare June 11, 2025 15:58
imeoer
imeoer approved these changes Jun 17, 2025
View reviewed changes
Copy link
Collaborator

@imeoer imeoer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@imeoer
Copy link
Collaborator

imeoer commented Jun 17, 2025

Let's fix the broken accel_check CI later.

@imeoer imeoer merged commit ddc79be into goharbor:main Jun 17, 2025
9 of 12 checks passed
@Fricounet
Copy link
Contributor Author

thanks @imeoer for the review. Would it be possible to cut a new release of the acceleration-service as well?
I've already tested (draft here) my branch in order to bump nydusify to containerd v2 and it does seem to solve correctly the issue allowing us to bump nydus-snapshotter in it.

I'll submit a PR there as soon as the acceleration-service has a new release so that I can use the new tag there.
🙏

@imeoer
Copy link
Collaborator

imeoer commented Jun 18, 2025 •
edited
Loading

I'll submit a PR there as soon as the acceleration-service has a new release so that I can use the new tag there. 🙏

@Fricounet Thanks for the work! The latest tag is v0.2.18: https://github.com/goharbor/acceleration-service/tree/v0.2.18

I'm working on fixing the broken release CI and will done for the next release, but now you can use the v0.2.18 tag first. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imeoer imeoer imeoer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Fricounet @imeoer