Skip to content

Fix Cookie SameSite constants to Pascal case per RFC specification #3608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Jul 27, 2025
+321 −34
Merged

Fix Cookie SameSite constants to Pascal case per RFC specification #3608

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
43cf3b0
Initial plan
Copilot Jul 20, 2025
61ea726
Fix Cookie SameSite constants to Pascal case per RFC spec
Copilot Jul 20, 2025
0a4a8b7
Implement ASCII case-insensitive SameSite comparison for better compa…
Copilot Jul 20, 2025
24f3f65
Implement allocation-free ASCII case-insensitive SameSite comparison
Copilot Jul 20, 2025
4275d1c
Replace custom equalASCIIFold with utils.EqualFold
Copilot Jul 20, 2025
5f997a2
Add comprehensive test coverage for case-insensitive SameSite cookie …
Copilot Jul 20, 2025
f817b00
Enable parallel execution for SameSite cookie case-insensitive tests
sixcolors Jul 20, 2025
309bc89
Automatically set Secure=true when SameSite=None per RFC requirements
Copilot Jul 20, 2025
ff30fe2
Document automatic Secure=true enforcement for SameSite=None cookies
Copilot Jul 20, 2025
503abec
Add Mozilla and Chrome documentation links for SameSite=None auto-sec…
Copilot Jul 20, 2025
e93391b
refactor: tests for case insensitivity, improve session cookie attrib…
sixcolors Jul 20, 2025
c84e69c
Merge branch 'copilot/fix-3607' of https://github.com/gofiber/fiber i…
sixcolors Jul 20, 2025
653312e
refactor: enhance SameSite cookie tests for case insensitivity and se…
sixcolors Jul 20, 2025
e0c9952
Merge branch 'main' into copilot/fix-3607
sixcolors Jul 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions constants.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -308,9 +308,9 @@ const (
// https://datatracker.ietf.org/doc/html/draft-ietf-httpbis-rfc6265bis-03#section-4.1.2.7
const (
CookieSameSiteDisabled = "disabled" // not in RFC, just control "SameSite" attribute will not be set.
CookieSameSiteLaxMode = "lax"
CookieSameSiteStrictMode = "strict"
CookieSameSiteNoneMode = "none"
CookieSameSiteLaxMode = "Lax"
CookieSameSiteStrictMode = "Strict"
CookieSameSiteNoneMode = "None"
)

// Route Constraints
Expand Down
2 changes: 1 addition & 1 deletion ctx.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -432,7 +432,7 @@ func (c *DefaultCtx) Cookie(cookie *Cookie) {

var sameSite http.SameSite

switch utils.ToLower(cookie.SameSite) {
switch cookie.SameSite {
case CookieSameSiteStrictMode:
sameSite = http.SameSiteStrictMode
case CookieSameSiteNoneMode:
Expand Down
Loading