Skip to content

🩹 Fix: Optimize Cache middleware handler #3031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 12, 2024
Merged

🩹 Fix: Optimize Cache middleware handler #3031

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c5cc690
Optimize cache handler
orvillesimba Jun 11, 2024
b747a49
revert to cfg.KeyGenerator(c) + _ + requestMethod
orvillesimba Jun 11, 2024
16f7c0a
Merge branch 'main' into optimize-cache
gaby Jun 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 5 additions & 9 deletions middleware/cache/cache.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
package cache

import (
"slices"
"strconv"
"strings"
"sync"
Expand Down Expand Up @@ -95,22 +96,17 @@ func New(config ...Config) fiber.Handler {
return c.Next()
}

// Only cache selected methods
var isExists bool
for _, method := range cfg.Methods {
if c.Method() == method {
isExists = true
}
}
requestMethod := c.Method()

if !isExists {
// Only cache selected methods
if !slices.Contains(cfg.Methods, requestMethod) {
c.Set(cfg.CacheHeader, cacheUnreachable)
return c.Next()
}

// Get key from request
// TODO(allocation optimization): try to minimize the allocation from 2 to 1
key := cfg.KeyGenerator(c) + "_" + c.Method()
key := cfg.KeyGenerator(c) + "_" + requestMethod

// Get entry from pool
e := manager.get(key)
Expand Down