Skip to content

Conversation

@NorbertHauriel
Copy link
Contributor

@NorbertHauriel NorbertHauriel commented Feb 2, 2022

  • The variable 'expire' doesn't imply why it is different from 'expiration', so I made its name more specific.
  • Comments mentioning it were changed accordingly.

@welcome
Copy link

welcome bot commented Feb 2, 2022

Thanks for opening this pull request! 🎉 Please check out our contributing guidelines. If you need help or want to chat with us, join us on Discord https://gofiber.io/discord

This clarifies the intent of variable 'expire' by renaming to
the more understandable 'resetInSec'. All mentions are renamed as well.
@NorbertHauriel NorbertHauriel marked this pull request as draft February 2, 2022 16:43
@NorbertHauriel NorbertHauriel marked this pull request as ready for review February 2, 2022 16:48
@NorbertHauriel NorbertHauriel changed the title ♻️ Refactor(limiter): remove and rename expiration variable Doc(limiter): clarify variable name 'expire' Feb 2, 2022
@ReneWerner87 ReneWerner87 merged commit d85ae2b into gofiber:master Feb 3, 2022
@welcome
Copy link

welcome bot commented Feb 3, 2022

Congrats on merging your first pull request! 🎉 We here at Fiber are proud of you! If you need help or want to chat with us, join us on Discord https://gofiber.io/discord

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants