Skip to content

Conversation

bruvzg
Copy link
Member

@bruvzg bruvzg commented Dec 7, 2022

Rename window_get_real_size to a more clear window_get_size_with_decorations. And add its position counterpart (decorations can be on all sides of the window, so size without origin is useless).

Screenshot 2022-12-07 at 11 51 22

…add `window_get_position_with_decorations`.
@akien-mga
Copy link
Member

That makes a lot of sense to me. This picture should find its way in the documentation :)

CC @Riteo FYI

@bruvzg
Copy link
Member Author

bruvzg commented Dec 7, 2022

This picture should find its way in the documentation :)

Actually, a lot of docs will benefit from some images, but we'll need a way to add it to the class ref docs. RTL supports embedding images, so it's not hard to implement, but the question is where to store them to avoid bloating the editor too much.

@akien-mga akien-mga merged commit 0a3f664 into godotengine:master Dec 7, 2022
@akien-mga
Copy link
Member

Thanks!

@akien-mga akien-mga modified the milestones: 4.x, 4.0 Dec 7, 2022
@bruvzg bruvzg deleted the real_size branch December 7, 2022 13:38
@deralmas
Copy link
Contributor

deralmas commented Dec 7, 2022

Oh, this is way better, I didn't understand what it did at all but now it's very clear, great work! I'll port this to my Wayland PR ASAP! Note though that I don't think that we can know the size with decorations with SSDs, nor we could do anything with it there either.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants