--convert-3to4 doesn't convert shaders #63673
Description
Godot version
System information
Win 10/64 NVIDIA GeForce GTX 1060/PCIe/SSE2
Issue description
According to my incomplete conversion log found in issue #63672, all my shaders in assets/shaders were converted. However the work is far from complete.
-
There are new .gdshader files, but all the old .shader files are still there and weren't deleted or renamed.
-
The new shaders have
render_mode async_visible, which GD4 doesn't support and gives an error. -
In fact, the shaders were hardly touched at all. The only difference I see is NORMAL_MAP. There are so many more issues.
These are all of the necessary conversions I have identified for my shaders. I'm not sure about backlight. It appears to be a functional replacement, but it is a poor quality replacement. I haven't decided if it needs an issue filed yet.
$line =~ s/async_visible,?//g;
$line =~ s/depth_draw_alpha_prepass/depth_draw_opaque/g;
$line =~ s/hint_color|hint_albedo/source_color/g;
$line =~ s/hint_white/hint_default_white/g;
$line =~ s/hint_black_albedo|hint_black/hint_default_black/g;
$line =~ s/hint_aniso/hint_anisotropy/g;
$line =~ s/NORMALMAP/NORMAL_MAP/g;
$line =~ s/INV_CAMERA_MATRIX/VIEW_MATRIX/g;
$line =~ s/CAMERA_MATRIX/INV_VIEW_MATRIX/g;
$line =~ s/WORLD_MATRIX/MODEL_MATRIX/g;
$line =~ s/TRANSMISSION/BACKLIGHT/g;
$line =~ s/ALPHA_SCISSOR/ALPHA_SCISSOR_THRESHOLD/g;