Skip to content

Update Environment and post-processing documentation for 4.0 #6273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 22, 2023
Merged

Update Environment and post-processing documentation for 4.0 #6273

merged 1 commit into from
Feb 22, 2023

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented Oct 6, 2022 •
edited
Loading

Marked as draft as this should be merged after #6216 (some links depend on that PR being merged – marked as TODO within this PR).

This documents sky materials, SSIL, 3D color correction LUT, CameraEffects, glow maps, and the editor preview sun and sky system.

The neutral 3D LUT example was generated using this project, which also includes neutral LUTs with various sizes and vertical layout if needed: https://github.com/Calinou/godot-3d-lut-demo

@Calinou Calinou added enhancement content:new page Issues and PRs related to creation of new documentation pages for new or undocumented features topic:rendering labels Oct 6, 2022
@Calinou Calinou mentioned this pull request Oct 6, 2022
Merged
@Calinou Calinou force-pushed the update-environment-post-processing-4.0 branch 4 times, most recently from 3d3e609 to fce47b5 Compare October 9, 2022 22:14
clayjohn
clayjohn reviewed Oct 12, 2022
View reviewed changes
Copy link
Member

@clayjohn clayjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work so far!

@Calinou Calinou mentioned this pull request Oct 13, 2022
Open
41 tasks
@Calinou Calinou force-pushed the update-environment-post-processing-4.0 branch 2 times, most recently from d5b692d to 5f1bc47 Compare November 10, 2022 18:30
@Calinou
Copy link
Member Author

Calinou commented Nov 10, 2022

I converted images to WebP and added a color correction import settings image that was previously missing.

@Calinou Calinou force-pushed the update-environment-post-processing-4.0 branch 2 times, most recently from adc27be to 8135093 Compare November 10, 2022 18:56
@Calinou Calinou mentioned this pull request Nov 13, 2022
Merged
@Calinou Calinou force-pushed the update-environment-post-processing-4.0 branch from 8135093 to 8873722 Compare November 14, 2022 23:10
@clayjohn clayjohn mentioned this pull request Nov 24, 2022
Closed
@Calinou Calinou force-pushed the update-environment-post-processing-4.0 branch from 8873722 to 12929fd Compare December 19, 2022 16:55
@skyace65 skyace65 added the area:manual Issues and PRs related to the Manual/Tutorials section of the documentation label Jan 13, 2023
@Calinou Calinou mentioned this pull request Jan 21, 2023
Closed
@skyace65
Copy link
Contributor

Just realized we merged the page that was needed for this. Making this ready for review.

@skyace65 skyace65 marked this pull request as ready for review February 12, 2023 20:47
@letmetrythisname
Copy link
Contributor

Very good work overall; only made minor edits to sentence structure, diction, corrections to passive voice, etc.

environment_and_post_processing.txt

@Calinou Calinou force-pushed the update-environment-post-processing-4.0 branch from 12929fd to c3b3425 Compare February 15, 2023 19:23
@Calinou
Copy link
Member Author

Calinou commented Feb 15, 2023

Very good work overall; only made minor edits to sentence structure, diction, corrections to passive voice, etc.

environment_and_post_processing.txt

Thanks! I've applied those changes and added you as a co-author 🙂

skyace65
skyace65 requested changes Feb 18, 2023
View reviewed changes
@Calinou Calinou force-pushed the update-environment-post-processing-4.0 branch from c3b3425 to 6cdbd6c Compare February 18, 2023 15:57
clayjohn
clayjohn reviewed Feb 21, 2023
View reviewed changes
@Calinou
Copy link
Member Author

Calinou commented Feb 21, 2023 •
edited
Loading

Yes, might as well remove the note entirely

Out of curiosity, why? That note seems relevant for people designing their own LUTs and people downloading LUTs online. LUTs generally have instructions on the expected input color space: https://github.com/h3r2tic/tony-mc-mapface#readme

@Calinou Calinou force-pushed the update-environment-post-processing-4.0 branch from 6cdbd6c to 55dbca3 Compare February 21, 2023 16:21
@clayjohn
Copy link
Member

Out of curiosity, why?

Because it was incorrect. The main render pass in 3D uses linear space when using an RD renderer, but the post processing pass is part linear and part sRGB. The LUT step itself takes an sRGB input and provides an sRGB output. Since textures are authored in sRGB space anyway, its fine to not call out the color space used.

@Calinou @letmetrythisname
Update Environment and post-processing documentation for 4.0
26a6729 
This documents sky materials, SSIL, 3D color correction LUT,
CameraEffects, glow maps, and the editor preview sun and sky system.

Co-authored-by: Isaac <[email protected]>
@Calinou Calinou force-pushed the update-environment-post-processing-4.0 branch from 55dbca3 to 26a6729 Compare February 21, 2023 18:40
@skyace65 skyace65 merged commit 70948ea into godotengine:master Feb 22, 2023
@Calinou Calinou deleted the update-environment-post-processing-4.0 branch February 22, 2023 17:13
@Calinou Calinou mentioned this pull request Mar 4, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skyace65 skyace65 skyace65 approved these changes

@clayjohn clayjohn clayjohn approved these changes

Assignees
No one assigned
Labels
area:manual Issues and PRs related to the Manual/Tutorials section of the documentation content:new page Issues and PRs related to creation of new documentation pages for new or undocumented features enhancement topic:rendering
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Calinou @skyace65 @letmetrythisname @clayjohn