Add ConnectWithContext method #135
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add variation to Connect() method that takes a context parameter
Test because go won't load latest version into mod cache
MKrupauskas
reviewed
Jul 24, 2024
| @@ -1,3 +1,2 @@ | |||
| module github.com/go-zookeeper/zk | |||
|
|
|||
| module github.com/test/zk | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add variation to Connect() method that takes a context parameter. This is a simple change that was mentioned in a TODO.
Note that canceling the context cannot (yet) be used to shut down the connection.