-
-
Notifications
You must be signed in to change notification settings - Fork 197
chore(deps): upgrade tailwind to v4 #1023
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
It seems like the problem is the prefix: I couldn't figure out how to set the prefix without importing the preflight at the same time. And having Bulma use the same layers as tailwind does not seem to make things simpler. Given how little we're using tailwind, maybe it's easier to just remove it? Or remove bulma? |
So preflight is necessary for prefix? That seems like a bug, no? |
Looks like it, but it might be interfering with how we use Bulma. |
@layer theme, utilities; | ||
|
||
@import "tailwindcss/theme.css" layer(theme) prefix(tw); | ||
@import "tailwindcss/utilities.css" layer(utilities) prefix(tw); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why didn't you import base and components?
/*
** see discussion under:
** [tailwindlabs/tailwindcss#17594 (comment)](https://github.com/tailwindlabs/tailwindcss/discussions/17594?utm_source=chatgpt.com#discussioncomment-12752302)
*/
@layer theme, base, components, utilities;
@import "tailwindcss/theme.css" layer(theme) prefix(tw);
@import "tailwindcss/utilities.css" layer(utilities);
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried, but it does not seem to make a difference
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What exactly is the issue?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks broken when adding it, looks broken when not adding it.
No description provided.