fix: CLI variables should take priority over Taskfile defaults #2589
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreynering
approved these changes
Dec 18, 2025
Member
andreynering
left a comment
andreynering
left a comment
There was a problem hiding this comment.
I haven't personally tested this, but I trust you if you have. Code looks good.
Contributor
|
I also tested it for both cases, and a few others, seems good. |
When using `task FOO=bar` with a Taskfile containing
`FOO: '{{.FOO | default "foo"}}'`, the CLI value was being
overwritten by the Taskfile default.
Split the variable merging into two steps:
1. Merge CLI variables (FOO=bar) first so they override Taskfile vars
2. ReverseMerge special variables (CLI_ARGS, CLI_FORCE, etc.) so
they're available for templating in Taskfile vars
Fixes regression introduced in #2403.
Co-authored-by: Timothy Rule <[email protected]>
vmaerten
force-pushed
the
fix/cli-vars-priority
branch
from
2cbb0df to
20f3416
Compare
andreynering
added a commit
that referenced
this pull request
Dec 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2588
When using
task FOO=barwith a Taskfile containingFOO: '{{.FOO | default "foo"}}', the CLI value was being overwritten by the Taskfile default.The ReverseMerge function was incorrectly allowing Taskfile variables to overwrite CLI globals. Now it skips variables that already exist in the CLI globals, ensuring user-provided values take priority while still making CLI globals available for templating.
Fixes regression introduced in #2403.