Fix concurrent writes to stdout in tests. #2350
Open
+13
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trulede
changed the title
pd93
approved these changes
Aug 5, 2025
andreynering
requested changes
Aug 7, 2025
✅ Deploy Preview for next-taskfile canceled.
|
|
I will have to tag the tests with "signals" (or delete them), its too difficult to get them running reliably in the CI. Edit: New tests removed. Useful for developing this PR, but otherwise not fitting well. |
trulede
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Writes to stdout from
depsare occasionally "mixed up". This is caused by concurrent writes to the executor stdout variable by go routines (from thedepswhich run in parallel). The solution proposed here captures stdout to a buffer, and then transfers that buffer to the executor stdout with the protection of mutex to avoid concurrent writes.The problem may be difficult to reproduce. My testing showed a 1-in-10 chance of the problem occurring when running the task tests. After correcting the issue I did not encounter failure for 30+ test runs.
fixes #2349
fixes #1208