ci: add new job to check if versioned_docs has been modified #1719
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vmaerten
changed the title
pd93
approved these changes
Jul 16, 2024
Member
pd93
left a comment
pd93
left a comment
There was a problem hiding this comment.
This is a really good idea. Thanks for catching the problem in those PRs. Are there any docs changes that have been overridden as a result of this?
Member
Author
|
@pd93 AFAIK, only for #1669, I made the change in #1717 (and @andreynering merged it) |
pd93
added a commit
that referenced
this pull request
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A small proposal: check in the CI if files under versioned_docs has been modified.
We had the issue twice (#1669 && #1673) so I think doing this check in the CI can be useful
EDIT : this one too : #1702
Here is what it looks like :
I've put it under
lintbecause I did not want to create another workflow file