Skip to content

Fix container push tag overwriting #35936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix container push tag overwriting #35936

wants to merge 1 commit into from
+41 −32

Conversation

@wxiaoguang
Copy link
Contributor

@wxiaoguang wxiaoguang commented Nov 12, 2025

Fix #35853

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 12, 2025
@github-actions github-actions bot added modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code labels Nov 12, 2025
@wxiaoguang wxiaoguang mentioned this pull request Nov 12, 2025
Open
@wxiaoguang
Copy link
Contributor Author

wxiaoguang commented Nov 12, 2025 •
edited
Loading

The code pv.CreatedUnix doesn't seem right (it might be only for debug purpose when fixing the problem)

Also manually tested with "docker push" and "docker buildx":

image image

@wxiaoguang wxiaoguang marked this pull request as draft November 12, 2025 13:42
@wxiaoguang wxiaoguang added this to the 1.26.0 milestone Nov 12, 2025
@wxiaoguang wxiaoguang marked this pull request as ready for review November 12, 2025 13:55
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 12, 2025
@wxiaoguang wxiaoguang mentioned this pull request Nov 13, 2025
Open
25 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lunny lunny lunny approved these changes

Assignees

No one assigned

Labels

backport/v1.25 lgtm/need 1 This PR needs approval from one additional maintainer to be merged. modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code type/bug

Projects

None yet

Milestone

1.26.0

Development

Successfully merging this pull request may close these issues.

Can't overwrite package tags

3 participants

@wxiaoguang @lunny @GiteaBot