Not() should drop error string #97
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…because non-empty
error
string counts as failed test byinternalCheck()
even ifresult
istrue
.Maybe this should be fixed in internalCheck() instead, I'm not sure. Neither this change nor alternative change in internalCheck() breaks any existing tests, so both changes are unlikely break compatibility, but proposed change have much higher chance to not break anything and makes more sense to me (the downside is losing error message, which is probably not valuable in this case anyway). So I think some new tests should be added with this change.