Close 1353 and 1928 make /NAN implied for several functions #1945
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tOrSet which consider the absence of /NAN as if Set. Makes GDL behave accordingly to IDL 8.5.1 and upper.
|
not yet merged, troubles with the GH continuous integration system. |
GillesDuvert
changed the title
GillesDuvert
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1945 +/- ##
==========================================
+ Coverage 42.06% 42.53% +0.46%
==========================================
Files 442 444 +2
Lines 109948 110079 +131
Branches 21990 22010 +20
==========================================
+ Hits 46253 46817 +564
+ Misses 63695 63262 -433 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
note alleged !version.release is now 8.5.1, the first one where /NAN is not needed anymore in calls. (or, to say differently, it is not necessary to add /NAN to a command where not-a-namber should be taken into account)