upstream upgrade to v1.4.8 #73
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
reviewed
Jun 11, 2025
| continue; | ||
| } | ||
|
|
||
| let blob_sidecar_result = 'sidecar: { |
Contributor
There was a problem hiding this comment.
gonna make this easier to use.
but does gnosis even have 4844 transactions?
if not we can just set the bundle to empty?
Member
Author
There was a problem hiding this comment.
actually GC does have 4844! since we're an L1, we preferred to keep blob txs. the tx count is very low till now tho i must say
onbjerg
pushed a commit
to ithacaxyz/odyssey
that referenced
this pull request
Jun 12, 2025
## Summary This PR migrates Odyssey from Reth 1.3.12 to 1.4.8, updating all related dependencies to match Reth's workspace versions. ### Dependency Updates - **Reth**: 1.3.12 → 1.4.8 - **Alloy**: 0.15 → 1.0.9 - **Op-alloy**: 0.15 → 0.17.2 - **Revm**: Updated to match Reth's versions - revm: 24.0.1 - revm-primitives: 19.0.0 - revm-interpreter: 20.0.0 - revm-precompile: 20 - revm-inspectors: 0.23.0 - op-revm: 5.0.0 - **Jsonrpsee**: 0.24 → 0.25.1 - **Tower**: 0.4 → 0.5 ### Breaking Changes Fixed 1. **NetworkBuilder trait update**: Changed `type Primitives` to `type Network` to match Reth 1.4.x API 2. **OpAddOns generic parameters**: Updated to include all 4 required type parameters (NodeAdapter, OpEthApiBuilder, OpEngineValidatorBuilder, OpEngineApiBuilder) 3. **Jsonrpsee API changes**: Removed deprecated `http_only()` method from Server builder 4. **Tower version compatibility**: Updated to 0.5 to match jsonrpsee requirements ### Test Results - ✅ All tests pass - ✅ No clippy warnings - ✅ Binary builds successfully --- > **Migration approach**: Referenced the reth-gnosis migration commits for guidance on updating dependencies and fixing breaking changes. The migration was straightforward with most changes being dependency version bumps and minor API adjustments. > > **Key references used**: > - Reth 1.4.8 workspace dependencies > - reth-gnosis migration PR: gnosischain/reth_gnosis#73 > - reth-gnosis migration commit: gnosischain/reth_gnosis@e76f50f > > **Prompts used to arrive at this result**: > - "Migrate this codebase from reth version 1.3.12 to version 1.4.8. This bump includes several breaking changes that we need to fix, dependency updates (see reth workspace dependencies that we need to mirror for alloy, op-alloy etc. https://github.com/paradigmxyz/reth/blob/main/Cargo.toml) for release notes that includes guides how to migrate certain breaking changes please look through the recent releases especially 1.4.0 https://github.com/paradigmxyz/reth/releases. A good reference is also this commit on reth-gnoses that did a similar migration gnosischain/reth_gnosis@e76f50f and can serve as a reference for how to migrate changes" > - "Theres an additional migration pr on reth-gnosis to reth 1.4.8 from 1.4.3 on reth gnosis that can be helpful https://github.com/gnosischain/reth_gnosis/pull/73/files" > - "we also need to mirror reth 1.4.8 alloy-evm and revm dependencies here" > - "make sure there are no clippy warnings in the workspace, then open a pr and summarize the migration and include the prompts used to arrive at this result as > comments at the end"
mev-smithxbg
added a commit
to mev-smithxbg/odyssey
that referenced
this pull request
Sep 28, 2025
## Summary This PR migrates Odyssey from Reth 1.3.12 to 1.4.8, updating all related dependencies to match Reth's workspace versions. ### Dependency Updates - **Reth**: 1.3.12 → 1.4.8 - **Alloy**: 0.15 → 1.0.9 - **Op-alloy**: 0.15 → 0.17.2 - **Revm**: Updated to match Reth's versions - revm: 24.0.1 - revm-primitives: 19.0.0 - revm-interpreter: 20.0.0 - revm-precompile: 20 - revm-inspectors: 0.23.0 - op-revm: 5.0.0 - **Jsonrpsee**: 0.24 → 0.25.1 - **Tower**: 0.4 → 0.5 ### Breaking Changes Fixed 1. **NetworkBuilder trait update**: Changed `type Primitives` to `type Network` to match Reth 1.4.x API 2. **OpAddOns generic parameters**: Updated to include all 4 required type parameters (NodeAdapter, OpEthApiBuilder, OpEngineValidatorBuilder, OpEngineApiBuilder) 3. **Jsonrpsee API changes**: Removed deprecated `http_only()` method from Server builder 4. **Tower version compatibility**: Updated to 0.5 to match jsonrpsee requirements ### Test Results - ✅ All tests pass - ✅ No clippy warnings - ✅ Binary builds successfully --- > **Migration approach**: Referenced the reth-gnosis migration commits for guidance on updating dependencies and fixing breaking changes. The migration was straightforward with most changes being dependency version bumps and minor API adjustments. > > **Key references used**: > - Reth 1.4.8 workspace dependencies > - reth-gnosis migration PR: gnosischain/reth_gnosis#73 > - reth-gnosis migration commit: gnosischain/reth_gnosis@e76f50f > > **Prompts used to arrive at this result**: > - "Migrate this codebase from reth version 1.3.12 to version 1.4.8. This bump includes several breaking changes that we need to fix, dependency updates (see reth workspace dependencies that we need to mirror for alloy, op-alloy etc. https://github.com/paradigmxyz/reth/blob/main/Cargo.toml) for release notes that includes guides how to migrate certain breaking changes please look through the recent releases especially 1.4.0 https://github.com/paradigmxyz/reth/releases. A good reference is also this commit on reth-gnoses that did a similar migration gnosischain/reth_gnosis@e76f50f and can serve as a reference for how to migrate changes" > - "Theres an additional migration pr on reth-gnosis to reth 1.4.8 from 1.4.3 on reth gnosis that can be helpful https://github.com/gnosischain/reth_gnosis/pull/73/files" > - "we also need to mirror reth 1.4.8 alloy-evm and revm dependencies here" > - "make sure there are no clippy warnings in the workspace, then open a pr and summarize the migration and include the prompts used to arrive at this result as > comments at the end"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Routine minor upgrade. Mainly done for this PR which relaxes header requirements (needed for custom header).