Skip to content

Conversation

@giacomolicari
Copy link
Contributor

No description provided.

@giacomolicari giacomolicari temporarily deployed to pr-review-enabling-revi-nchmoy September 4, 2023 11:14 Inactive
@giacomolicari giacomolicari temporarily deployed to pr-review-enabling-revi-nchmoy September 4, 2023 11:30 Inactive
@giacomolicari giacomolicari temporarily deployed to pr-review-enabling-revi-nchmoy September 4, 2023 11:42 Inactive
@giacomolicari giacomolicari temporarily deployed to pr-review-enabling-revi-nchmoy September 4, 2023 12:31 Inactive
@giacomolicari giacomolicari temporarily deployed to pr-review-enabling-revi-nchmoy September 4, 2023 12:42 Inactive
@giacomolicari giacomolicari temporarily deployed to pr-review-enabling-revi-nchmoy September 4, 2023 12:50 Inactive
@giacomolicari giacomolicari temporarily deployed to pr-review-enabling-revi-nchmoy September 4, 2023 12:52 Inactive
@giacomolicari giacomolicari temporarily deployed to pr-review-enabling-revi-nchmoy September 4, 2023 12:55 Inactive
@giacomolicari giacomolicari temporarily deployed to pr-review-enabling-revi-nchmoy September 4, 2023 14:33 Inactive
@giacomolicari giacomolicari temporarily deployed to pr-review-enabling-revi-nchmoy September 4, 2023 14:36 Inactive
@giacomolicari giacomolicari temporarily deployed to pr-review-enabling-revi-nchmoy September 4, 2023 14:37 Inactive
@giacomolicari giacomolicari temporarily deployed to pr-review-enabling-revi-nchmoy September 4, 2023 14:39 Inactive
@giacomolicari giacomolicari temporarily deployed to pr-review-enabling-revi-nchmoy September 4, 2023 14:43 Inactive
@giacomolicari giacomolicari temporarily deployed to pr-review-enabling-revi-nchmoy September 4, 2023 15:01 Inactive
@giacomolicari giacomolicari temporarily deployed to pr-review-enabling-revi-nchmoy September 4, 2023 16:02 Inactive
@giacomolicari giacomolicari temporarily deployed to pr-review-enabling-revi-nchmoy September 4, 2023 16:05 Inactive
@giacomolicari giacomolicari temporarily deployed to pr-review-enabling-revi-nchmoy September 4, 2023 16:08 Inactive
@giacomolicari giacomolicari temporarily deployed to pr-review-enabling-revi-nchmoy September 4, 2023 16:24 Inactive
- name: NPM Install and Build
run: |
npm install
npm run build
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just as a reminder for me: I'll have to update this in #25.

@filoozom filoozom changed the title Enable Heroku review-apps Enable PR previews Sep 4, 2023
@giacomolicari giacomolicari temporarily deployed to pr-review-enabling-revi-nchmoy September 4, 2023 18:52 Inactive

- uses: actions/setup-node@v3
with:
node-version-file: 'package.json'
Copy link
Contributor

@filoozom filoozom Sep 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't seem to be documented really well but is seemingly supported indeed. A few references in case we need them at some point:

@giacomolicari giacomolicari temporarily deployed to pr-review-enabling-revi-nchmoy September 5, 2023 06:26 Inactive
@giacomolicari giacomolicari temporarily deployed to pr-review-enabling-revi-nchmoy September 5, 2023 06:30 Inactive
@giacomolicari giacomolicari merged commit 0715cda into main Sep 5, 2023
@giacomolicari giacomolicari deleted the enabling-reviewapps branch September 5, 2023 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants