Skip to content

Add solution reversion to graph data script #1025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 20, 2020
Merged

Add solution reversion to graph data script #1025

merged 1 commit into from
Oct 20, 2020

Conversation

@fleupold
Copy link
Contributor

This PR adds a competitive solution submission (suboptimal replaced by optimal solution) to our graph data script, so that we can use it for e2e tests in gnosis/dex-subgraph#119

Test Plan

Make sure script runs without errors against ganache.

@fleupold fleupold requested review from bh2smith and nlordell October 20, 2020 18:07
nlordell
nlordell approved these changes Oct 20, 2020
View reviewed changes
Copy link
Contributor

@nlordell nlordell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. I find it unfortunate that this script is part of dex-contracts and not dex-subgraph though. Although it would be a non-trivial task to move it over unfortunately.

@fleupold fleupold merged commit 769a104 into master Oct 20, 2020
@fleupold fleupold deleted the graph_data_with_reversion branch October 20, 2020 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bh2smith bh2smith Awaiting requested review from bh2smith

1 more reviewer

@nlordell nlordell nlordell approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@fleupold @nlordell