-
Notifications
You must be signed in to change notification settings - Fork 424
feat: add 'gnokey add -entropy' #4586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: moul <[email protected]>
🛠 PR Checks SummaryAll Automated Checks passed. ✅ Manual Checks (for Reviewers):
Read More🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers. ✅ Automated Checks (for Contributors):🟢 Maintainers must be able to edit this pull request (more info) ☑️ Contributor Actions:
☑️ Reviewer Actions:
📚 Resources:Debug
|
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
Signed-off-by: moul <[email protected]>
fyi, I am currently writing a txtar. However, due to the lack of stdin, I am considering adding stdin support to txtar or allowing the specification of entropy as a flag. |
Signed-off-by: moul <[email protected]>
Signed-off-by: moul <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 💯
Left minor comments 🙏
Signed-off-by: moul <[email protected]>
Signed-off-by: moul <[email protected]>
Signed-off-by: moul <[email protected]>
Signed-off-by: moul <[email protected]>
@gfanton i’ve also updated the txtar engine, can you give a look please? |
Signed-off-by: moul <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This idea is really cool! 👍
I would be curious to see a comparison between mouse movements (like on VeraCrypt, for example) and this dice-throwing method, measuring the time / "quality of the entropy" ratio generated in both cases (a lot more data produced in the case of mouse movements but more "pure" randomness in the case of dice-rolling).
Mouse-related concepts are difficult to verify, so no one verifies them. These concepts are essentially gray. I prefer that people choose any method while being aware that they have the option to select the most verifiable one available. We will also share a guide for airgap computers using this method to ensure that the setup is correct (e.g., using legitimate dice, etc.). |
Signed-off-by: moul <[email protected]>
Demo: