Unquote userame and password to accept slashes as on rfc3986 #93
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 78.33%@@ master #93 diff @@
========================================
Files 16 16
Lines 1874 1874
Methods 0 0
Branches 0 0
========================================
Hits 1468 1468
Misses 406 406
Partials 0 0 |
|
When do you have planned to make a release? It would be very usefull to us if we could get the last changes from pypi. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use usernames that have slashes on them in the form
domain/usernameand rabbitpy was failing to parse the urls. Quoting slashes with %2f did not help, because a unquoting was missing after parsinghttps://www.ietf.org/rfc/rfc3986.txt