Add configurable timeouts #85
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see that it breaks 2.6. Unable to test it, unfortunately. |
|
Thanks for that, would you mind resubmitting with only the timeout changes and split out the locale change to a new PR along with the bug fix in the rabbitpy/amqp? It makes it easier to track that way. Also your PR breaks in both Python 2.6 and 3.2. |
|
done. Python 3.2 seems to be broken before my edits. |
|
If you take a look at the error, it is in coverage package, which clearly states that it does not support python 3.2. It used to support it, perhaps, but you forgot to freeze the versions in your requirements file. |
|
@gmr You need to add something like this for Coverage to work with Python 3.2, or don't use Coverage 4.x at all. =] |
canardleteer
added a commit
to canardleteer/rabbitpy
that referenced
this pull request
Feb 27, 2016
canardleteer
pushed a commit
to canardleteer/rabbitpy
that referenced
this pull request
Mar 10, 2016
- AMQP.basic_publish() would spit out the following: ValueError: channel must be a valid rabbitpy Channel object This is resolved and added to the unit tests. - Coverage patch for Travis-CI (from @eandersson: gmr#85)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in #84