Date: Fix parser lookup (use descending order) #732
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parseDate fails on Turkish full datetime with Monday or Saturday. The root cause is that the parser lookup finds Cuma (Fri) before it finds Cumartesi (Sat), similarly it finds Pazar (Sun) before it finds Pazartesi (Mon), and therefore the token doesn't entirely consume the input. The fix approach is to start the lookup with longer names, then the shorter ones. Fixes globalizejs#690
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
parseDate fails on Turkish full datetime with Monday or Saturday.
The root cause is that the parser lookup finds Cuma (Fri) before it
finds Cumartesi (Sat), similarly it finds Pazar (Sun) before it finds
Pazartesi (Mon), and therefore the token doesn't entirely consume the
input.
The fix approach is to start the lookup with longer names, then the
shorter ones.
Fixes #690