-
Notifications
You must be signed in to change notification settings - Fork 27
Updates for build.gradle and tested Proguard #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
@@ -16,3 +17,7 @@ allprojects { | |||
} | |||
} | |||
} | |||
|
|||
task wrapper(type: Wrapper) { | |||
gradleVersion = '2.2.1' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This whole task is not needed. Once the wrapper has been checked in you can just edit the properties file to update it.
@JakeWharton I have removed the extra task and used the |
Multidex works fine with Dagger 2. It just doesn't work with the current architecture. It would be trivial to alter the behavior. |
@JakeWharton You have used MultiDex + DI before? I have had issues with Roboguice + MultiDex in the past. What do you mean current architecture? |
The documentation for multidex states that you need to defer having classes The current design forces Dagger classes to be loaded before the multidex However, I don't think we should attempt to showcase absolutely every
|
@JakeWharton I understand. I just wanted to be able to add Proguard to the working Android sample that uses Dagger 2.0. Should I remove the MultiDex line? |
Yeah let's remove it. We'll make another app sample somewhere to showcase
|
Added and tested Proguard
@JakeWharton Will you showcase Dagger 2.0 + MutliDex in a separate project soon? I was hoping to utilize both Proguard and MultiDex with Dagger 2.0. |
Proguard should work without any actual changes. But yeah we can make a
|
@JakeWharton Yes! I saw you posted that somewhere. I agree and I would like to contribute. You posted here: |
@gk5885 @JakeWharton Was there anything else that needed to change for this pull request? |
@gk5885 Any updates on this? |
buildToolsVersion
inbuild.gradle
com.android.tools.build:gradle
inbuild.gradle
wrapper
release
tobuildTypes
enabling Proguard withminifyEnabled
andshrinkResources
which verifies: http://stackoverflow.com/questions/26024694/how-to-successfully-obfuscate-project-with-dagger-2-0-using-proguard