This repository was archived by the owner on May 21, 2024. It is now read-only.
Add support for GCR #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@benjlevesque Thanks for the PR, I'll take a look, and would definitely like to get this landed. |
bigkevmcd
suggested changes
Oct 22, 2020
| Use: "pubsub", | ||
| Short: "update repositories in response to gcr pubsub events", | ||
| RunE: func(cmd *cobra.Command, args []string) error { | ||
| zapl, _ := zap.NewProduction() |
There was a problem hiding this comment.
I wonder if some of this code which is duplicated from the http command could be extracted and reused?
pkg/hooks/gcr/hook_test.go
Outdated
| return b | ||
| } | ||
|
|
||
| type failingReader struct { |
There was a problem hiding this comment.
I'd probably be inclined to move this to a file in https://github.com/gitops-tools/image-updater/tree/main/test (it'll need to become FailingReader
There was a problem hiding this comment.
I actually forgot to remove it, it is only used in handler_test now, is it fine to leave it there?
bigkevmcd
approved these changes
Oct 24, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new command
pubsubto receive Google Cloud Registry events.To support both HTTP requests and Pubsub events,
PushEventParserhave been modified to accept[]byteinstead ofhttp.Request.The HTTP request Body now being parsed in the
handler, tests related to the parsing of an invalid request have been moved to thehandlerpackage.This project is exactly what I have been looking for to manage image updates, thanks!
Also, I'm pretty new to go, so feel free to suggest changes / refactorings.