"Delete Branch" option is sometimes unexpectedly missing

[eamodio]

Continued from #3514

Originally posted by @DmitryEfimenko in #3514 (comment)

There's now potentially a related issue. The "Delete Branch" option is completely gone. Previously, the "Delete option" would not show when you are on the branch that you want to delete. But, I made sure it's not the case.

Also, see the result of these commands:

git worktree list
C:/Source/art/art-backend  b5033fb [master]

git branch
  fix/75
* master

It's worth mentioning that I experience the issue with missing "Delete Branch" button in one repository, but not the other. Although, my git workflow is usually the same. Not sure what the difference is

[eamodio]

@DmitryEfimenko Thanks so much for the extra information!

Can you please verify this fix in tomorrow's (v2024.09.16xx) pre-release edition of GitLens? Thank you so much!

You can switch to the pre-release edition of GitLens, by clicking on the "Switch to Pre-Release version of this extension" from the Extensions view.

[eamodio]

To verify:

• Open VS Code with a repo with 2 branches (A & B)
• Start on branch A
• Verify that Delete Branch... IS NOT on the context menu for branch A (since it is the current branch)
• Verify that Delete Branch... IS on the context menu for branch B
• Switch to branch B
• Verify that Delete Branch... IS on the context menu for branch A
• Verify that Delete Branch... IS NOT on the context menu for branch B (since it is now the current branch)

[axosoft-ramint]

To verify:

• Open VS Code with a repo with 2 branches (A & B)
• Start on branch A
• Verify that Delete Branch... IS NOT on the context menu for branch A (since it is the current branch)
• Verify that Delete Branch... IS on the context menu for branch B
• Switch to branch B
• Verify that Delete Branch... IS on the context menu for branch A
• Verify that Delete Branch... IS NOT on the context menu for branch B (since it is now the current branch)

Verified using the above steps.