-
Notifications
You must be signed in to change notification settings - Fork 4.8k
Add GDShader #7071
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GDShader #7071
Conversation
lildude
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can't accept an unlicensed grammar. All grammars must have a licence and it must be one of these to be accepted:
linguist/vendor/licenses/config.yml
Lines 4 to 15 in 9b1023e
| - apache-2.0 | |
| - bsd-2-clause | |
| - bsd-3-clause | |
| - cc0-1.0 | |
| - isc | |
| - mit | |
| - mpl-2.0 | |
| - ncsa | |
| - permissive | |
| - unlicense | |
| - wtfpl | |
| - zlib |
|
Ok, I removed https://github.com/godotengine/godot-vscode-plugin Also supports GDShader (and GDScript) and has the MIT license - but it seems like this grammar is already included in the project, so I can't add it |
lildude
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove the vendor/grammars/SublimeGodot submodule. We don't need it.
|
The PR is good to go but I can't merge it whilst it still has the unneeded |
Forgot all about this, I'll get to that now |
lildude
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks.
Important
The changes in this PR will not appear on GitHub until the next release has been made and deployed. See here for more details.
Description
Adds support for GDShader / Godot Shading Language. Will close the issue I made for it: #7067
GDShader is the shading language used for Godot Engine https://godotengine.org/
It is very similar to GLSL https://docs.godotengine.org/en/stable/tutorials/shaders/shader_reference/shading_language.html
This language has been known by the community as both GDShader and Godot Shading Language, as it lacked a true name. This problem was solved and it is officially being known as GDShader. (see godotengine/godot-proposals#10784)
Checklist:
In same order of sources:
#478CBF#355570, so I didn't want to use an exact same color. I was thinking from the start to differentiate them I would still use a shade of Godot blue, but lighter. So I went and color-picked the Godot Engine logo and it was the perfect color - still a Godot color but enough to differentiate from GDScript files.