Skip to content

Conversation

@FireCatMagic
Copy link
Contributor

@FireCatMagic FireCatMagic commented Oct 1, 2024

Description

Adds support for GDShader / Godot Shading Language. Will close the issue I made for it: #7067
GDShader is the shading language used for Godot Engine https://godotengine.org/
It is very similar to GLSL https://docs.godotengine.org/en/stable/tutorials/shaders/shader_reference/shading_language.html

This language has been known by the community as both GDShader and Godot Shading Language, as it lacked a true name. This problem was solved and it is officially being known as GDShader. (see godotengine/godot-proposals#10784)

Checklist:

@FireCatMagic FireCatMagic requested a review from a team as a code owner October 1, 2024 23:54
@FireCatMagic FireCatMagic changed the title Added GDShader Add GDShader Oct 1, 2024
Copy link
Member

@lildude lildude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't accept an unlicensed grammar. All grammars must have a licence and it must be one of these to be accepted:

- apache-2.0
- bsd-2-clause
- bsd-3-clause
- cc0-1.0
- isc
- mit
- mpl-2.0
- ncsa
- permissive
- unlicense
- wtfpl
- zlib

@FireCatMagic
Copy link
Contributor Author

Ok, I removed gdshader-lsp

https://github.com/godotengine/godot-vscode-plugin Also supports GDShader (and GDScript) and has the MIT license - but it seems like this grammar is already included in the project, so I can't add it

@FireCatMagic FireCatMagic requested a review from lildude October 4, 2024 18:53
Copy link
Member

@lildude lildude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the vendor/grammars/SublimeGodot submodule. We don't need it.

@lildude lildude added the Stale label Apr 25, 2025
@lildude
Copy link
Member

lildude commented Jun 2, 2025

The PR is good to go but I can't merge it whilst it still has the unneeded vendor/grammars/SublimeGodot submodule.

@FireCatMagic
Copy link
Contributor Author

The PR is good to go but I can't merge it whilst it still has the unneeded vendor/grammars/SublimeGodot submodule.

Forgot all about this, I'll get to that now

@FireCatMagic FireCatMagic requested a review from lildude June 2, 2025 16:05
Copy link
Member

@lildude lildude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

Important

The changes in this PR will not appear on GitHub until the next release has been made and deployed. See here for more details.

@lildude lildude added this pull request to the merge queue Jun 3, 2025
Merged via the queue into github-linguist:main with commit 865ad2a Jun 3, 2025
5 checks passed
@github-linguist github-linguist locked as resolved and limited conversation to collaborators Sep 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants