Skip to content

Conversation

@karpikpl
Copy link
Collaborator

Supporting custom scopes for GitHub

Signed-off-by: Piotr Karpala <[email protected]>
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (2)

server/routes/auth/github.get.ts:4

  • [nitpick] Consider trimming whitespace from the resulting scope strings after splitting to ensure they match the expected values for GitHub's OAuth scopes.
scope: process.env.NUXT_OAUTH_GITHUB_CLIENT_SCOPE ? process.env.NUXT_OAUTH_GITHUB_CLIENT_SCOPE.split(',') : undefined,

app/components/MainComponent.vue:152

  • [nitpick] The updated error message now uses double quotes for organization details; ensure that this change aligns with the overall string formatting guidelines applied across the project for consistency.
apiError.value = `404 Not Found - is the ${config.public.scope || ''} org:"${config.public.githubOrg || ''}" ent:"${config.public.githubEnt || ''}" team:"${config.public.githubTeam}" correct? ${error.message}`;

@karpikpl karpikpl merged commit 658b3b5 into main Feb 25, 2025
5 checks passed
@karpikpl karpikpl deleted the feature/github-scopes branch February 25, 2025 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GitHub Standalone integration with GitHub App not working

3 participants