Health check endpoints are returning 500 errors without a token

[sebastienbonami]

Environment

• Deployment in Kubernetes
• Docker image ghcr.io/github-copilot-resources/copilot-metrics-viewer:2.1.1
• NUXT_GITHUB_TOKEN not set on purpose

Description

Hi, I tested deploying the application in Kubernetes using a GitHub App for authentication. In that scenario, the Liveness and Readiness probes, configured as suggested in the README, are returning 500 errors.

Configuring NUXT_GITHUB_TOKEN prevents this, but I don't want to use a token here as I don't want just anyone to be able to see the data.

I tried all 3 health check endpoints in my browser and they work if I'm signed in with my GitHub account on the application, but not if I'm signed out.

The README actually says that these endpoints don't require authentication so there's certainly an issue here.

Thanks in advance.

[karpikpl]

hmm, that's strange. I've recently merged a PR to remove AUTH from the /health endpoints

[karpikpl]

I think I need to exclude health endpoints here:

copilot-metrics-viewer/server/middleware/github.ts

Lines 27 to 30 in 0849c3f

	// Skip authentication for non-API routes
	if (!url.startsWith('/api/')) {
	return;
	}