Skip to content

fix: Tag non jit instances with runner id and add docs #4667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 21, 2025

Conversation

npalm
Copy link
Member

@npalm npalm commented Jul 20, 2025

⚠️ This PR is on top of #4539

This pull request is an enhancement on top of #4539. The PR also introduces tagging via the start scripts for non-JIT configured instances. And it adds a state diagram to the ever growing complexity of the state diagram below terminating instances.

Instance Tagging Enhancements:

  • Add function to tag runners with runner id for non JIT instances. Functions are designed to ignore errors to avoid causing a crash of the runner registration process.
  • side effect is that the instance is allowed to create the tag ghr:github_runner_id the instance is allowed to create the tag only on itself.

Added docs

  • State diagram for scale-down added
Untitled diagram _ Mermaid Chart-2025-07-20-140732

@npalm npalm self-assigned this Jul 21, 2025
@npalm npalm requested a review from stuartp44 July 21, 2025 06:37
Copy link
Contributor

@stuartp44 stuartp44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@npalm npalm merged commit 9aa3203 into stu/add_tag_plus_check Jul 21, 2025
42 checks passed
@npalm npalm deleted the npal/add_tag_plus_check branch July 21, 2025 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants