fix: restrict runner security group to only ingress #3564
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
npalm
approved these changes
Oct 26, 2023
There was a problem hiding this comment.
@ThomasLachaux I think the security group is not openm now rules are defined. But with your additon potential drift will get detected. Which means added rules (mannually) will be removed.
npalm
pushed a commit
that referenced
this pull request
Oct 26, 2023
🤖 I have created a release *beep* *boop* --- ## [4.7.0](philips-labs/terraform-aws-github-runner@v4.6.0...v4.7.0) (2023-10-26) ### Features * Add public IP association to github runner ([#3547](https://github.com/philips-labs/terraform-aws-github-runner/issues/3547)) ([1a25b2c](philips-labs/terraform-aws-github-runner@1a25b2c)) ### Bug Fixes * add tags to aws resources ([#3549](https://github.com/philips-labs/terraform-aws-github-runner/issues/3549)) ([c747139](philips-labs/terraform-aws-github-runner@c747139)) * restrict runner security group to only ingress ([#3564](https://github.com/philips-labs/terraform-aws-github-runner/issues/3564)) ([e63fdc5](philips-labs/terraform-aws-github-runner@e63fdc5)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: forest-releaser[bot] <80285352+forest-releaser[bot]@users.noreply.github.com>
npalm
pushed a commit
that referenced
this pull request
Oct 26, 2023
Runner security group is currently open. This patch removes the default ingress rule security group to deny everything. More info on [this documentation](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/security_group#removing-all-ingress-and-egress-rules).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Runner security group is currently open.
This patch removes the default ingress rule security group to deny everything.
More info on this documentation.