Skip to content

expand options for sourcing lambda to include S3 #292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 4, 2020

Conversation

eky5006
Copy link
Contributor

@eky5006 eky5006 commented Oct 26, 2020

Submitting a small change to expand the options for sourcing the lambda functions to include S3. Using an S3 bucket would be an alternative to providing local files directly and providing the bucket itself would be up to the user.

We found that a change like this is personally better for our workflow and could be useful for others too. Thanks for the great work on this project!

@npalm
Copy link
Member

npalm commented Oct 27, 2020

Thx will check asap

@npalm npalm self-requested a review October 27, 2020 09:27
Copy link
Member

@npalm npalm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eky5006 looks good to me, I wade some small documentation adjustments myself.

@npalm npalm merged commit 6377708 into github-aws-runners:develop Nov 4, 2020
@eky5006 eky5006 deleted the lambda-s3-source branch November 4, 2020 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants