[engine] #713 요구사항 적용 #739
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ytaek
reviewed
Sep 29, 2024
| } | ||
|
|
||
| export async function getLogCount(gitPath: string, currentWorkspacePath: string): Promise<number> { | ||
| const decimal = 10; |
There was a problem hiding this comment.
변수의 이름은 변수의 실제 역할로 표현하는 것이 좋을 것 같습니다.
여기서는 값을 뜻하는 decimal 보다는
10이 어떤 역할을 하는 변수인지 표현하면 더 좋겠네요!
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue
Result
#713 에서 말씀하신 요구사항을 적용하였습니다.
Work list
getLogCount의 코드의 가독성과 유지 보수성 향상pakages/vscode/webpack.config.js주석 제거packages/vscode/src/extension.ts주석 제거