Skip to content

git-completion: sanitize the command names #229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MrMebelMan wants to merge 1 commit into
base: master
Choose a base branch
from
Open

git-completion: sanitize the command names #229

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions contrib/completion/git-completion.bash
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2853,6 +2853,7 @@ __git_support_parseopt_helper () {
__git_complete_command () {
local command="$1"
local completion_func="_git_${command//-/_}"
[[ "$command" =~ [^a-z-] ]] && return 1
if ! declare -f $completion_func >/dev/null 2>/dev/null &&
declare -f _completion_loader >/dev/null 2>/dev/null
then
Expand Down
3 changes: 2 additions & 1 deletion contrib/completion/git-completion.zsh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,8 +116,9 @@ __git_zsh_bash_func ()
emulate -L ksh

local command=$1

local completion_func="_git_${command//-/_}"

[[ "$command" =~ [^a-z-] ]] && return
declare -f $completion_func >/dev/null && $completion_func && return

local expansion=$(__git_aliased_command "$command")
Expand Down