Skip to content

Conversation

@sunshineplan
Copy link
Contributor

@sunshineplan sunshineplan commented Sep 10, 2024

fixed #2795

This pull request implements the functionality to load HTML templates directly from an http.FileSystem. The changes aim to enhance the framework's flexibility in handling HTML templates by introducing support for http.FileSystem.

@codecov
Copy link

codecov bot commented Sep 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.86%. Comparing base (3dc1cd6) to head (eb4a5e1).
Report is 104 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4053      +/-   ##
==========================================
- Coverage   99.21%   98.86%   -0.36%     
==========================================
  Files          42       44       +2     
  Lines        3182     2811     -371     
==========================================
- Hits         3157     2779     -378     
- Misses         17       19       +2     
- Partials        8       13       +5     
Flag Coverage Δ
?
-tags "sonic avx" 98.85% <100.00%> (?)
-tags go_json 98.85% <100.00%> (?)
-tags nomsgpack 98.83% <100.00%> (?)
go-1.18 ?
go-1.19 ?
go-1.20 ?
go-1.21 98.85% <100.00%> (-0.37%) ⬇️
go-1.22 98.85% <100.00%> (?)
macos-latest 98.85% <100.00%> (-0.37%) ⬇️
ubuntu-latest 98.85% <100.00%> (-0.37%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@erik-nilcoast
Copy link

This would have just saved me some issues in production :). It'd be great if gin supported this.

@appleboy appleboy added this to the v1.11 milestone Apr 20, 2025
@appleboy appleboy changed the title Implement loading HTML from http.FileSystem feat(fs): Implement loading HTML from http.FileSystem Apr 20, 2025
@appleboy appleboy merged commit 71496ab into gin-gonic:master Apr 20, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

If method loading html files from embed.FS type could be helpful??

3 participants